ABAP Training Example BC400.doc

*&-*& report sapbc400cid_code_inspector_1 *&-*& *& this program contains some bad programming techniques *& that should be found by the code inspector . *& *&-* is this ok ?report my_program.* selection text ?parameters pa_carr type s_carr_id.data wa_conn type sdyn_conn.* what is missing here ?authority-check object s_carrid id carrid field pa_carr id actvt field 03.select * from spfli into corresponding fields of wa_conn where carrid = pa_carr.* performance ? select single carrname from scarr into wa_conn-carrname where carrid = wa_conn-carrid. write: / wa_conn-carrname, wa_conn-carrid, wa_conn-connid, wa_conn-cityfrom, wa_conn-cityto, wa_conn-deptime, wa_conn-arrtime.endselect.* is this ok ?break-point.if sy-subrc ne 0.* translation ? write no connections found !.endif.*&-*& report sapbc400cid_code_inspector_2 *&-*& *& corrected version of sapbc400cid_code_inspector_1 *& *&-*report sapbc400cid_code_inspector_2 .parameters pa_carr type s_carr_id.data wa_conn type sdyn_conn.authority-check object s_carrid id carrid field pa_carr id actvt field 03.if sy-subrc ne 0. write authority check failed !(acf). exit.endif.select * from bc400_cisd_fli select from a buffered view into corresponding fields of wa_conn where carrid = pa_carr. write: / wa_conn-carrname, wa_conn-carrid, wa_conn-connid, wa_conn-cityfrom, wa_conn-cityto, wa_conn-deptime, wa_conn-arrtime.endselect.if sy-subrc ne 0. write no connections found !(ncf).endif.*&-*& report sapbc400ddd_array_fetch *&-*& *& reading one database table via array fetch (select . into table) *& *&-*report sapbc400ddd_array_fetch.data: itab_spfli type sbc400_t_spfli, wa_spfli like line of itab_spfli.select carrid connid airpfrom cityfrom countryfr airpto cityto countryto deptime from spfli into corresponding fields of table itab_spfli.loop at itab_spfli into wa_spfli. write: / wa_spfli-carrid, wa_spfli-connid, wa_spfli-airpfrom, wa_spfli-cityfrom, wa_spfli-countryfr, wa_spfli-airpto, wa_spfli-cityto, wa_spfli-countryto, wa_spfli-deptime.endloop.*&-*& report sapbc400ddd_select_endselect *&-*& *& reading one database table via select . endselect. *& *&-*report sapbc400ddd_select_endselect.parameters pa_car type s_carr_id.data wa_sbc400focc type sbc400focc.select carrid connid fldate seatsmax seatsocc from sflight into wa_sbc400focc where carrid = pa_car. wa_sbc400focc-percentage = wa_sbc400focc-seatsocc * 100 / wa_sbc400focc-seatsmax. write: / wa_sbc400focc-carrid, wa_sbc400focc-connid, wa_sbc400focc-fldate, wa_sbc400focc-seatsmax, wa_sbc400focc-seatsocc, wa_sbc400focc-percentage, %.endselect.*&-*& report sapbc400ddd_select_inner_join *&-*& *& read data from two database tables via apab inner join : *& *& select . from . inner join . *& *&-*report sapbc400ddd_select_inner_join .types: begin of wa_type, carrid type scarr-carrid, carrname type scarr-carrname, connid type spfli-connid, airpfrom type spfli-airpfrom, cityfrom type spfli-cityfrom, countryfr type spfli-countryfr, airpto type spfli-airpto, cityto type spfli-cityto, countryto type spfli-countryto, deptime type spfli-deptime, end of wa_type.data wa_join type wa_type.* selecting from inner join (to avoid nested select loops)select scarrcarrid scarrcarrname spfliconnid spfliairpfrom spflicityfrom spflicountryfr spfliairpto spflicityto spflicountryto spflideptime into corresponding fields of wa_join from scarr inner join spfli on scarrcarrid = spflicarrid. write: / wa_join-carrid, wa_join-carrname, wa_join-connid, wa_join-airpfrom, wa_join-cityfrom, wa_join-countryfr, wa_join-airpto, wa_join-cityto, wa_join-countryto, wa_join-deptime.endselect.*&-*& report sapbc400ddd_select_single *&-*& *& reading single entry from database : select single *& *&-*report sapbc400ddd_select_single .parameters pa_car type s_carr_id.data wa_scarr type scarr.select single * from scarr into corresponding fields of wa_scarr where carrid = pa_car.if sy-subrc = 0. write: / wa_scarr-carrid, wa_scarr-carrname, wa_scarr-currcode.else . write: / text-001 color col_negative.endif.*&-*& report sapbc400ddd_select_view *&-*& *& *&-*report sapbc400ddd_select_view .parameters pa_anum type s_agncynum.data wa_sbc400_booking type sbc400_booking.select mandt carrid connid fldate bookid customid class name street city country agencynum from sbc400_booking into wa_sbc400_booking where agencynum = pa_anum. write: / wa_sbc400_booking-carrid, wa_sbc400_booking-connid, wa_sbc400_booking-fldate, wa_sbc400_booking-bookid, wa_sbc400_booking-customid, wa_sbc400_booking-class, wa_sbc400_booking-name, wa_sbc400_booking-street, wa_sbc400_booking-city, wa_sbc400_booking-country, wa_sbc400_booking-agencynum.endselect.*&-*& report sapbc400dds_authority_check *&-*report sapbc400dds_authority_check.constants actvt_display type activ_auth value 03.data wa_flight type sbc400focc.parameters pa_car type s_carr_id.* check if user is authorized to read data of the specified carrierauthority-check object s_carrid id carrid field pa_car id actvt field actvt_display.case sy-subrc. when 0. user is authorized select carrid connid fldate seatsmax seatsocc from sflight into corresponding fields of wa_flight where carrid = pa_car. wa_flight-percentage = 100 * wa_flight-seatsocc / wa_flight-seatsmax. write: / wa_flight-carrid color col_key, wa_flight-connid color col_key, wa_flight-fldate color col_key, wa_flight-seatsocc, wa_flight-seatsmax, wa_flight-percentage, %. endselect. if sy-subrc ne 0. write: no , pa_car, flights found !. endif. when others. user is not authorized write: / authority-check error(001).endcase.*&-*& report sapbc400dds_authority_check_2 *&-*report sapbc400dds_authority_check_2.constants actvt_display type activ_auth value 03.data: it_flight type sbc400_t_sbc400focc, wa_flight like line of it_flight.parameters pa_car type s_carr_id.* check if user is authorized to read data of the specified carrier ?authority-check object s_carrid id carrid field pa_car id actvt field actvt_display.case sy-subrc. when 0. user is authorized select carrid connid fldate seatsmax seatsocc from sflight into corresponding fields of wa_flight where carrid = pa_car. wa_flight-percentage = 100 * wa_flight-seatsocc / wa_flight-seatsmax. append wa_flight to it_flight. endselect. if sy-subrc = 0. sort it_flight by percentage. loop at it_flight into wa_flight. write: / wa_flight-carrid color col_key, wa_flight-connid color col_key, wa_flight-fldate color col_key, wa_flight-seatsocc, wa_flight-seatsmax, wa_flight-percentage, %. endloop. else. write: no , pa_car, flights found !. endif. when others. user is not authorized write: / authority-check error(001).endcase.*&-*& report sapbc400dds_select_array_fetch *&-*report sapbc400dds_select_array_fetch.data: it_flight type sbc400_t_sbc400focc, wa_flight like line of it_flight.parameters pa_car type s_carr_id.*-* - use array fetch to fill internal table * - loop at internal table to set the percentage value of each row * - sort and list internal table *-select carrid connid fldate seatsmax seatsocc from sflight into corresponding fields of table it_flight where carrid = pa_car.if sy-subrc = 0. loop at it_flight into wa_flight. wa_flight-percentage = 100 * wa_flight-seatsocc / wa_flight-seatsmax. modify it_flight from wa_flight index sy-tabix transporting percentage. endloop. sort it_flight by percentage. loop at it_flight into wa_flight. write: / wa_flight-carrid, wa_flight-connid, wa_flight-fldate, wa_flight-seatsocc, wa_flight-seatsmax, wa_flight-percentage, %. endloop.else. write: no , pa_car, flights found !.endif.*&-*& report sapbc400dds_select_sflight *&-*& solution for exercise reading data from one database table *&-*report sapbc400dds_select_sflight.parameters pa_car type s_carr_id.data wa_flight type sbc400focc.* select all flights belonging to carrier specified in pa_car :select carrid connid fldate seatsmax seatsocc from sflight into corresponding fields of wa_flight where carrid = pa_car.* calculate occupation of the current flight wa_flight-percentage = 100 * wa_flight-seatsocc / wa_flight-seatsmax.* create list write: / wa_flight-carrid, wa_flight-connid, wa_flight-fldate, wa_flight-seatsmax, wa_flight-seatsocc, wa_flight-percentage, %.endselect.if sy-subrc ne 0. write: no , pa_car, flights found !.endif.*&-*& report sapbc400dds_select_sflight_tab *&-*report sapbc400dds_select_sflight_tab .data: it_flight type sbc400_t_sbc400focc, wa_flight like line of it_flight.parameters pa_car type s_carr_id.* select all flights belonging to carrier specified in pa_car :select carrid connid fldate seatsmax seatsocc from sflight into corresponding fields of wa_flight where carrid = pa_car.* calculate occupation of flight wa_flight-percentage = 100 * wa_flight-seatsocc / wa_flight-seatsmax.* insert flight into internal table insert wa_flight into table it_flight.* (if you are using standard tables, append wa_flight to it_flight.* would be the same as the above insert-statement.)endselect.if sy-subrc = 0.* sort internal table sort it_flight by percentage.* create list loop at it_flight into wa_flight. write: / wa_flight-carrid, wa_flight-connid, wa_flight-fldate, wa_flight-seatsocc, wa_flight-seatsmax, wa_flight-percentage, %. endloop.else. write: no , pa_car, flights found !.endif.*&-*& report sapbc400ias_ewt *&-*report sapbc400ias_ewt .data gdt_spfli type sbc400_t_spfli.data ok_code like sy-ucomm.data: container_r type ref to cl_gui_custom_container, grid_r type ref to cl_gui_alv_grid.start-of-selection.* fill internal table select * from spfli into table gdt_spfli.* where . call screen 100.*&-*& module user_command_0100 input*&-* text*-*module user_command_0100 input. case ok_code. when back. set screen 0. when exit. leave program. endcase.endmodule. user_command_0100 input*&-*& module status_0100 output*&-* text*-*module status_0100 output. set pf-status status_100.* set titlebar xxx.endmodule. status_0100 output*&-*& module create_control output*&-* text*-*module create_control output. if container_r is initial. create object container_r exporting container_name = container_1. create object grid_r exporting i_parent = container_r. call method grid_r-set_table_for_first_display exporting i_structure_name = spfli changing it_outtab = gdt_spfli. else. call method grid_r-refresh_table_di