codereview培训手册training_phase_07_code_rev

1、Parasoft Concerto TrainingPhase 7 Code Review2012The Phased Implementation PlanPhased implementation plan ensures success编辑编辑pptMore about ConcertoTOOLS PRESENTATION编辑编辑pptWhy do Code Review?Find defects earlyFind real functional problemsIncrease breadth of understandingLeads to increased productivi

2、ty编辑编辑pptMethods of Code ReviewCode Review “in a room”Wastes timeDevelopers are inhibitedUsing an automated infrastructureconsistent编辑编辑pptPutting it togetherThe next slides show how to do itPlanningSetting up tasksPerforming the workTwo methods for code reviewPre-commitPost-commitFirst phase of cod

3、e review should be pre-commit编辑编辑pptDetermining ReviewersWho reviews whomHow close are they in the code?Increase code understanding编辑编辑pptDeveloper 1Developer 2Developer 3Developer 4When to use pre-commitShouldnt be for normal experienced developersSetup policies to determine when to useNew develope

4、rsNew team membersSignificant code changesMore than 2-3 files for a single fix编辑编辑pptCode Review Workflow编辑编辑pptWhen is it enough?When everyone agreesPre-commit will hold up other development effortsBalance between full review and getting things done编辑编辑pptCode Review HistoryConcerto stores everythi

5、ngGreat for accountabilityWhat what you sayCONCERTO CR HISTORY DEMO编辑编辑pptReview Classifications编辑编辑pptReading the Review Graph编辑编辑pptReview Task ClassificationNew issues by severityReviewer classifiesNew issues by category编辑编辑pptReviewers Tasks编辑编辑pptReviews and code base编辑编辑pptWhat shouldnt you lo

6、ok atCode formation use static analysisBeautificationNaming conventions Some are related to functionality check thosePattern based should be checked in SA编辑编辑pptWhat should you look at?Metrics violationsThings not covered by static analysisFunctionalityExtend understanding of the code编辑编辑pptThings t

7、o look forMake sure source control comments are meaningfultask ID is in the review comments so you know what the change is related toTry to understand what theyre trying to doWhat is the logicHow does it fit the overall systemHow “clean” is the codeProper design patterns MOST IMPORTANTDoes each clas

8、s do one thingDoes each method do one thingAre methods named according to what they do?Naming should fit编辑编辑pptMore to look forRefactoringWhat is the general impact of the change being made?Do you know other areas the change will affect?Design patterns used are they appropriate?Other policies编辑编辑ppt

9、Reviewing code formattingNormally trust the SA tool to do thisNew developers doing pre-commit get extra scrutinyLegacy code is a challengeContested policies are a challengeThey dont belong in early adoption, or even later.As people used to doing SA and CodeReview it becomes easier to introduce such changes.编辑编辑pptPost-commit code reviewWho reviews whom is keyGuarantees that 100% of modified code is reviewed For experienced developersUse for smaller changes编辑编辑pptMonitoring the processUse the HealthCheck in PolicyCenter编辑编辑pptSetting H